test(zk): add test for create2 computation with L2Contract #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(test:zk): extract `computeCreate2Address`
elfedy
reviewed
Aug 27, 2024
chore: use consistent variable name
elfedy
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(test:zk): extract
computeCreate2AddressMotivation
We have tests to check that CREATE2 works and that it produces the expected address, but not that the expected address matches what L2ContractHelper computes.
Solution
Add a test which depends on the L2ContractHelper to compute the address.
Notes
All tests of this kind (checkin create2 address is correct) have been moved to the new test (which has some deps) as a logical group